create stores lazily #638
Merged
create stores lazily #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i like it!! we can probably also build on this to fix the issue with async rendering on the server that @tornqvist mentioned in choojs/bankai#427 (comment) |
|
@goto-bus-stop yes, exactly! |
goto-bus-stop
approved these changes
Mar 7, 2018
2 tasks
goto-bus-stop
pushed a commit
to goto-bus-stop/choo
that referenced
this pull request
Aug 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize stores lazily. Opens up the way to run multiple instances of the same app on the server, by passing a custom state all the way down.
This was initially suggested by @diffcunha, and I think it's a pretty decent idea!
Thanks!